Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: only include miri on the nightly channel #59544

Merged
merged 1 commit into from
Mar 30, 2019

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Mar 30, 2019

miri needs to build std with xargo, which doesn't allow stable/beta:
japaric/xargo#204 (comment)

Therefore, at this time there's no point in making miri available on any
but the nightly channel. If we get a stable way to build std, like
RFC 2663, then we can re-evaluate whether to start including miri,
perhaps still as miri-preview.

miri needs to build std with xargo, which doesn't allow stable/beta:
<japaric/xargo#204 (comment)>

Therefore, at this time there's no point in making miri available on any
but the nightly channel.  If we get a stable way to build `std`, like
[RFC 2663], then we can re-evaluate whether to start including miri,
perhaps still as `miri-preview`.

[RFC 2663]: rust-lang/rfcs#2663
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2019
@cuviper
Copy link
Member Author

cuviper commented Mar 30, 2019

cc @rust-lang/release @RalfJung @oli-obk

@Centril
Copy link
Contributor

Centril commented Mar 30, 2019

👍

r? @Centril

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2019

📌 Commit b222b6f has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 30, 2019
manifest: only include miri on the nightly channel

miri needs to build std with xargo, which doesn't allow stable/beta:
<japaric/xargo#204 (comment)>

Therefore, at this time there's no point in making miri available on any
but the nightly channel.  If we get a stable way to build `std`, like
[RFC 2663], then we can re-evaluate whether to start including miri,
perhaps still as `miri-preview`.

[RFC 2663]: rust-lang/rfcs#2663
bors added a commit that referenced this pull request Mar 30, 2019
Rollup of 5 pull requests

Successful merges:

 - #59343 (rustc(codegen): uncache `def_symbol_name` prefix from `symbol_name`.)
 - #59380 (Fix invalid DWARF for enums when using ThinLTO)
 - #59463 (skip dyn keyword lint under macros)
 - #59539 (Fix infinite recursion)
 - #59544 (manifest: only include miri on the nightly channel)

Failed merges:

r? @ghost
@bors bors merged commit b222b6f into rust-lang:master Mar 30, 2019
@RalfJung
Copy link
Member

RalfJung commented Apr 6, 2019

Is it possible that this caused #59746 (no Miri component available any more)?

@cuviper cuviper deleted the miri-nightly branch May 17, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants